abhishekagarwal87 commented on code in PR #12612:
URL: https://github.com/apache/druid/pull/12612#discussion_r890868885
##########
processing/src/main/java/org/apache/druid/jackson/JacksonModule.java:
##########
@@ -43,28 +47,37 @@ public void configure(Binder binder)
}
@Provides @LazySingleton @Json
- public ObjectMapper jsonMapper()
+ public ObjectMapper jsonMapper(Properties props)
{
- return new DefaultObjectMapper();
+ return new DefaultObjectMapper(getServiceName(props));
}
/**
* Provides ObjectMapper that suppress serializing properties with null
values
*/
@Provides @LazySingleton @JsonNonNull
- public ObjectMapper jsonMapperOnlyNonNullValue()
+ public ObjectMapper jsonMapperOnlyNonNullValue(Properties props)
{
- return new
DefaultObjectMapper().setSerializationInclusion(JsonInclude.Include.NON_NULL);
+ return new
DefaultObjectMapper(getServiceName(props)).setSerializationInclusion(JsonInclude.Include.NON_NULL);
}
@Provides @LazySingleton @Smile
- public ObjectMapper smileMapper()
+ public ObjectMapper smileMapper(Properties props)
Review Comment:
I think it is alright like this. There is just one test that needs zero-arg
constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
