gianm commented on code in PR #12592: URL: https://github.com/apache/druid/pull/12592#discussion_r894621690
########## indexing-service/src/main/java/org/apache/druid/indexing/overlord/ForkingTaskRunner.java: ########## @@ -635,7 +646,7 @@ public Optional<ScalingStats> getScalingStats() @Override public void start() Review Comment: Yeah, I think you're right. I think it makes sense to add the annotations in the impls, because not all impls necessarily need lifecycle management. I added it here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
