AmatyaAvadhanula commented on code in PR #12404:
URL: https://github.com/apache/druid/pull/12404#discussion_r897979523
##########
server/src/main/java/org/apache/druid/metadata/SQLMetadataStorageActionHandler.java:
##########
@@ -311,7 +325,126 @@ public List<TaskInfo<EntryType, StatusType>> getTaskInfos(
);
}
- protected Query<Map<String, Object>> createCompletedTaskInfoQuery(
+ @Override
+ public List<TaskInfo<TaskMetadata, StatusType>>
getTaskMetadataInfosFromPayload(
+ Map<TaskLookupType, TaskLookup> taskLookups,
+ @Nullable String dataSource
+ )
+ {
+ return getTaskMetadataInfos(taskLookups, dataSource, true);
+ }
+
+ @Override
+ public List<TaskInfo<TaskMetadata, StatusType>> getTaskMetadataInfos(
+ Map<TaskLookupType, TaskLookup> taskLookups,
+ @Nullable String dataSource
+ )
+ {
+ return getTaskMetadataInfos(taskLookups, dataSource, false);
+ }
+
+ public List<TaskInfo<TaskMetadata, StatusType>> getTaskMetadataInfos(
+ Map<TaskLookupType, TaskLookup> taskLookups,
+ @Nullable String dataSource,
+ boolean fetchPayload
+ )
+ {
+ ResultSetMapper<TaskInfo<TaskMetadata, StatusType>> resultSetMapper =
+ fetchPayload ? taskMetadataInfoMapperFromPayload :
taskMetadataInfoMapper;
+ return getConnector().retryTransaction(
+ (handle, status) -> {
+ final List<TaskInfo<TaskMetadata, StatusType>> taskMetadataInfos =
new ArrayList<>();
+ for (Entry<TaskLookupType, TaskLookup> entry :
taskLookups.entrySet()) {
+ final Query<Map<String, Object>> query;
+ switch (entry.getKey()) {
+ case ACTIVE:
+ query = !fetchPayload
Review Comment:
done
##########
server/src/main/java/org/apache/druid/metadata/SQLMetadataStorageActionHandler.java:
##########
@@ -311,7 +325,126 @@ public List<TaskInfo<EntryType, StatusType>> getTaskInfos(
);
}
- protected Query<Map<String, Object>> createCompletedTaskInfoQuery(
+ @Override
+ public List<TaskInfo<TaskMetadata, StatusType>>
getTaskMetadataInfosFromPayload(
+ Map<TaskLookupType, TaskLookup> taskLookups,
+ @Nullable String dataSource
+ )
+ {
+ return getTaskMetadataInfos(taskLookups, dataSource, true);
+ }
+
+ @Override
+ public List<TaskInfo<TaskMetadata, StatusType>> getTaskMetadataInfos(
+ Map<TaskLookupType, TaskLookup> taskLookups,
+ @Nullable String dataSource
+ )
+ {
+ return getTaskMetadataInfos(taskLookups, dataSource, false);
+ }
+
+ public List<TaskInfo<TaskMetadata, StatusType>> getTaskMetadataInfos(
+ Map<TaskLookupType, TaskLookup> taskLookups,
+ @Nullable String dataSource,
+ boolean fetchPayload
+ )
+ {
+ ResultSetMapper<TaskInfo<TaskMetadata, StatusType>> resultSetMapper =
+ fetchPayload ? taskMetadataInfoMapperFromPayload :
taskMetadataInfoMapper;
+ return getConnector().retryTransaction(
+ (handle, status) -> {
+ final List<TaskInfo<TaskMetadata, StatusType>> taskMetadataInfos =
new ArrayList<>();
+ for (Entry<TaskLookupType, TaskLookup> entry :
taskLookups.entrySet()) {
+ final Query<Map<String, Object>> query;
+ switch (entry.getKey()) {
+ case ACTIVE:
+ query = !fetchPayload
+ ? createActiveTaskSummaryStreamingQuery(handle,
dataSource)
+ : createActiveTaskStreamingQuery(handle, dataSource);
+ taskMetadataInfos.addAll(query.map(resultSetMapper).list());
+ break;
+ case COMPLETE:
+ CompleteTaskLookup completeTaskLookup = (CompleteTaskLookup)
entry.getValue();
+ DateTime priorTo = completeTaskLookup.getTasksCreatedPriorTo();
+ Integer limit = completeTaskLookup.getMaxTaskStatuses();
+ query = !fetchPayload
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
