paul-rogers commented on code in PR #12708:
URL: https://github.com/apache/druid/pull/12708#discussion_r921704656
##########
sql/src/main/java/org/apache/druid/sql/calcite/planner/DruidPlanner.java:
##########
@@ -172,18 +171,19 @@ public ValidationResult validate(boolean
authorizeContextParams) throws SqlParse
* Prepare an SQL query for execution, including some initial parsing and
validation and any dynamic parameter type
* resolution, to support prepared statements via JDBC.
*
- * In some future this could perhaps re-use some of the work done by {@link
#validate(boolean)}
+ * In some future this could perhaps re-use some work done by {@link
#validate(boolean)}
* instead of repeating it, but that day is not today.
*/
+ // RelConversionException is no longer thrown, but removing it causes
Review Comment:
Right. From SqlLifecycle, the exception is exposed to the callers, which
include the tests. Many tests then expose the exception in their test function
signatures. So, to fully clean up, we have to clean up many test functions.
That's the work to be done in another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
