maytasm commented on code in PR #12792:
URL: https://github.com/apache/druid/pull/12792#discussion_r933666114
##########
extensions-core/kinesis-indexing-service/src/main/java/org/apache/druid/indexing/kinesis/KinesisRecordSupplier.java:
##########
@@ -666,6 +670,30 @@ public String
getEarliestSequenceNumber(StreamPartition<String> partition)
return getSequenceNumber(partition, ShardIteratorType.TRIM_HORIZON);
}
+ @Override
+ public boolean isOffsetAvailable(StreamPartition<String> partition,
OrderedSequenceNumber<String> offset)
Review Comment:
This is quite different from the current logic in
KinesisRecordSupplier#getSequenceNumber.
such as handling when `closed` or the Retry for kinesis.getRecords
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
