clintropolis commented on PR #12831: URL: https://github.com/apache/druid/pull/12831#issuecomment-1200063644
>I don't see new tests added, only changing of old tests. Was the bad behavior actually captured and encoded in those tests such that changing them is now verifying good behavior? Is there really no new thing that we can add to also test the bug fix here? The new test is https://github.com/apache/druid/pull/12831/files#diff-886d639244f5abe97ecb6fcfed49b7f6baaa041b10d843982e82984c9f5653a4R316 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
