gianm commented on issue #12838:
URL: https://github.com/apache/druid/issues/12838#issuecomment-1200226165

   Some things we'll need to tackle:
   
   1. [Strong 
encapsulation](https://dev.java/learn/strong-encapsulation-\(of-jdk-internals\)/)
 in Java 17 means that Druid requires various `--add-opens` and `--add-exports` 
parameters in order to function. Skipping these parameters leads to errors on 
startup, or, worse, an unstable experience. We need to provide these to the 
Java runtime without users having to explicitly configure them.
   2. [DataSketches Memory](https://github.com/apache/datasketches-memory) does 
not currently support Java 14+ for all functionality. We use this both directly 
and via individual DataSketches. One specific incompatibility that I've noticed 
is memory-mapping files larger than 2GB in FrameFile. The unit tests explicitly 
skip this on Java 15: see `FrameTestUtil#jdkCanDataSketchesMemoryMap`. There 
may be other places as well.
   3. Run unit and integration tests on Java 17. (We can stop running in Java 
15 when we do this; Java 15 isn't an LTS so there isn't much need to test both.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to