rohangarg opened a new pull request, #12944:
URL: https://github.com/apache/druid/pull/12944
A user might construct a timeseries query on inline data by mistake which
contains no filters on time intervals (hence the query is on ETERNITY interval)
and also specifies a non-ALL granularity. Currently, those queries will start
generating a large number of time grains while generating the results which can
lead to a very high chance for heap OOM or a very very long query runtime.
This change disallows such queries from execution to avoid the problems
mentioned above. Semantically as well, there is less point in running a time
granularity query over the ETERNITY interval.
An augmentation to the solution could be to find the time-interval of the
inline data by traversing it and then using that interval in the
`RowBasedStorageAdapater`. But doing that change today will either require
recompuation of inline data or eager materialization of it in the adapater,
both of which approaches have their own short-comings. So, for now this change
is refrained - it can be considered in future if needed.
This PR has:
- [x] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [x] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [x] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [x] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
