clintropolis opened a new pull request, #12947: URL: https://github.com/apache/druid/pull/12947
### Description Adds additional limits `maxBytesInMemory` and `maxClientResponseBytes` to the Druid sampler API config, to augment existing options of `numRows` and `timeoutMs`. While these two configs are quite similar, `maxBytesInMemory` is oriented around controlling how big the `IncrementalIndex` which performs the sampling will be, while `maxClientResponseBytes` is an attempt to allow clients to specify the maximum size of response they would prefer to handle, which might vary significantly from `maxBytesInMemory`. `maxClientResponseBytes` is done in a rather sad way of serializing (and throwing away) the sampler rows and counting the bytes. In the future we might want to rework the sampler API to be a streaming API and do the counting of this stuff and enforcement of limits a bit more naturally. This PR has: - [x] been self-reviewed. - [ ] added documentation for new or modified features or behaviors. - [x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [x] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
