zemin-piao commented on PR #12950:
URL: https://github.com/apache/druid/pull/12950#issuecomment-1239787739
> Unfortunately, I found this patch to be invalid after deploying it to a
cluster of mine. #13045 is posted to fix in master and will also need to be
backported to 24.0.0
ooops yeah
`Splitter.on(",").split(returnedProperties.get("druid.server.hiddenProperties")).forEach(hiddenProperties::add);`
does not work properly with the property array with '[]'. I reused this part
from the existing test but should have caught this bug sooner indeed ...
Thanks a bunch for spotting it and fix it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
