kfaraz commented on code in PR #13157:
URL: https://github.com/apache/druid/pull/13157#discussion_r984180945
##########
website/.spelling:
##########
@@ -55,6 +55,7 @@ DRUIDVERSION
DataSketches
DateTime
DateType
+decomissioning
Review Comment:
Nit: two Ms
##########
docs/configuration/index.md:
##########
@@ -911,7 +911,7 @@ Issuing a GET request at the same URL will return the spec
that is currently in
|`killPendingSegmentsSkipList`|List of data sources for which pendingSegments
are _NOT_ cleaned up if property `druid.coordinator.kill.pendingSegments.on` is
true. This can be a list of comma-separated data sources or a JSON array.|none|
|`maxSegmentsInNodeLoadingQueue`|The maximum number of segments that could be
queued for loading to any given server. This parameter could be used to speed
up segments loading process, especially if there are "slow" nodes in the
cluster (with low loading speed) or if too much segments scheduled to be
replicated to some particular node (faster loading could be preferred to better
segments distribution). Desired value depends on segments loading speed,
acceptable replication time and number of nodes. Value 1000 could be a start
point for a rather big cluster. Default value is 100. |100|
|`decommissioningNodes`| List of historical servers to 'decommission'.
Coordinator will not assign new segments to 'decommissioning' servers, and
segments will be moved away from them to be placed on non-decommissioning
servers at the maximum rate specified by
`decommissioningMaxPercentOfMaxSegmentsToMove`.|none|
-|`decommissioningMaxPercentOfMaxSegmentsToMove`| The maximum number of
segments that may be moved away from 'decommissioning' servers to
non-decommissioning (that is, active) servers during one Coordinator run. This
value is relative to the total maximum segment movements allowed during one run
which is determined by `maxSegmentsToMove`. If
`decommissioningMaxPercentOfMaxSegmentsToMove` is 0, segments will neither be
moved from _or to_ 'decommissioning' servers, effectively putting them in a
sort of "maintenance" mode that will not participate in balancing or assignment
by load rules. Decommissioning can also become stalled if there are no
available active servers to place the segments. By leveraging the maximum
percent of decommissioning segment movements, an operator can prevent active
servers from overload by prioritizing balancing, or decrease decommissioning
time instead. The value should be between 0 and 100.|70|
+|`decommissioningMaxPercentOfMaxSegmentsToMove`| Upper limit of segments the
Coordinator can move from decommissioning servers to active,
non-decommissioning, servers during a single run. This value is relative to the
total maximum segment movements allowed during one run based upon the value of
`maxSegmentsToMove`.<br><br>If `decommissioningMaxPercentOfMaxSegmentsToMove`
is 0, the Coordinator does not move segments to decommissioning servers,
effectively putting them in a type of "maintenance" mode. In this case,
decommissioning servers do not participate in balancing or assignment by load
rules. The Coordinator still considers segments on decommissioning servers as
candidates to move or replicate on active servers.<br><br>Decommissioning can
stall if there are no available active servers to place the segments. You can
use the maximum percent of decommissioning segment movements to prioritize
balancing or to decrease commissioning time to prevent active servers from
being overloade
d. The value should be between 0 and 100.|70|
Review Comment:
To clarify, when `decommissioningMaxPercentOfSegmentsToMove` is 0, segments
on decommissioning servers are not considered eligible for move.
Suggestions:
1. The Coordinator still considers segments on decommissioning servers as
candidates to ~~move or~~ replicate on active servers.
2. Decommissioning can stall if there is no available active server to
~~place the segments~~ move segments to. ("place" is ambiguous as it might
refer to both replication or balancing)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
