paul-rogers commented on PR #13106: URL: https://github.com/apache/druid/pull/13106#issuecomment-1263118482
@kfaraz, thanks for your comments. Here are a few answers. The `TestCaseWriter` class is, indeed, part of the code that can convert existing tests. There are some changes to the `BaseCalciteQuery` and `DruidPlanner` classes that capture the items we might want to capture. There is also some code that munges the results for things like vectorize-or-not and other options. The result is that existing tests can be converted by enabling the conversion step, running the existing steps, then saving the result as the new "expected" values. The vast majority of tests convert without issue. A few are fiddly, or do special things. These can be left in Java, or can use the "advanced" tricks such as test options or copying selected parts of tests. The code to do the conversion is part of the next PR; though it has been suggested that we combine that code with this PR to give the reviewers the full picture (at the cost of more code to review.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
