599166320 commented on PR #13168: URL: https://github.com/apache/druid/pull/13168#issuecomment-1277705153
@paul-rogers Now these tasks should have been completed, please help me check if I am missing something? **1.Decide the level at which to sort. (Per-batch, per-cursor, or per-segment.)** _`ScanQueryOrderByRunner` and `ScanQueryOrderBySequence `should have done each batch-level sorting and segment-level sorting._ **2.Finish up the sorter for this case.** _`QueueBasedSorter` should have the characteristics of the sorter you describe._ **3.Finish up the merge code** _`ScanQueryOrderByMergeRowIterator` is applied to both historical-level and broker-level merges_ **4.Test with a data set that spans multiple segments & cursors to ensure all the levels listed earlier work as expected.** _This test class `ScanQueryResultOrderingTest` should already satisfy the test needs you describe_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
