gianm commented on code in PR #13259:
URL: https://github.com/apache/druid/pull/13259#discussion_r1004036956
##########
sql/src/main/java/org/apache/druid/sql/DirectStatement.java:
##########
@@ -301,6 +302,7 @@ public void cancel()
public void close()
{
if (state != State.START && state != State.CLOSED) {
+ // super.close calls closeQuietly, which removes us from the
sqlLifecycleManager.
Review Comment:
Ah, now that I read this again, I see that `closeQuietly` is called by both
`close` and `closeWithError`. So we can do the second thing you suggested: only
clean up the statement there. I just pushed up another commit with this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
