abhagraw commented on PR #13374:
URL: https://github.com/apache/druid/pull/13374#issuecomment-1320809774
> Another nit we should fix in this PR :
>
> ```
> 2022-11-18T19:26:19,074 INFO [main]
org.apache.druid.testing.utils.TestQueryHelper - Sql Task submitted with task
Id - query-77b14a7e-999d-4756-92eb-9fba59f68836
>
> 2022-11-18T19:26:19,105 WARN [main]
org.apache.druid.java.util.common.RetryUtils - Retrying (1 of 99) in 895ms.
>
>
org.apache.druid.testing.utils.MsqTestQueryHelper$TaskStillRunningException:
null
>
> at
org.apache.druid.testing.utils.MsqTestQueryHelper.lambda$pollTaskIdForCompletion$0(MsqTestQueryHelper.java:163)
~[druid-integration-tests-25.0.0-SNAPSHOT.jar:25.0.0-SNAPSHOT]
>
> at
org.apache.druid.java.util.common.RetryUtils.retry(RetryUtils.java:129)
~[druid-core-25.0.0-SNAPSHOT.jar:25.0.0-SNAPSHOT]
>
> at
org.apache.druid.java.util.common.RetryUtils.retry(RetryUtils.java:81)
~[druid-core-25.0.0-SNAPSHOT.jar:25.0.0-SNAPSHOT]
>
> at
org.apache.druid.java.util.common.RetryUtils.retry(RetryUtils.java:163)
~[druid-core-25.0.0-SNAPSHOT.jar:25.0.0-SNAPSHOT]
>
> at
org.apache.druid.java.util.common.RetryUtils.retry(RetryUtils.java:153)
~[druid-core-25.0.0-SNAPSHOT.jar:25.0.0-SNAPSHOT]
>
> ```
>
> ```java
> public TaskState pollTaskIdForCompletion(String taskId) throws Exception
> {
> return RetryUtils.retry(
> () -> {
> TaskStatusPlus taskStatusPlus =
overlordClient.getTaskStatus(taskId);
> TaskState statusCode = taskStatusPlus.getStatusCode();
> if (statusCode != null && statusCode.isComplete()) {
> return taskStatusPlus.getStatusCode();
> }
> throw new TaskStillRunningException();
> },
> (Throwable t) -> t instanceof TaskStillRunningException,
> 100
> );
> }
> ```
>
> Let's change this method to not throw an exception but just log unable to
get the status of the task. We can do this as part of another PR as well.
Used quite retry - so that not all retries throw the exception + stacktrace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
