somu-imply commented on code in PR #13268:
URL: https://github.com/apache/druid/pull/13268#discussion_r1035504546
##########
processing/src/main/java/org/apache/druid/segment/ColumnarValueUnnestCursor.java:
##########
@@ -68,7 +70,10 @@ public ColumnSelectorFactory getColumnSelectorFactory()
@Override
public DimensionSelector makeDimensionSelector(DimensionSpec
dimensionSpec)
{
- return baseColumSelectorFactory.makeDimensionSelector(dimensionSpec);
+ if (!outputName.equals(dimensionSpec.getDimension())) {
+ return baseColumSelectorFactory.makeDimensionSelector(dimensionSpec);
+ }
+ return
baseColumSelectorFactory.makeDimensionSelector(DefaultDimensionSpec.of(columnName));
Review Comment:
Addressed, added an unit test for the exception as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
