kfaraz commented on PR #13369: URL: https://github.com/apache/druid/pull/13369#issuecomment-1333336126
@AmatyaAvadhanula , @abhishekagarwal87 , thanks for the review. I have addressed your feedback. Changes made: - Queue polling is now always active irrespective of being leader or not. This can be improved later if needed. - Queue polling starts on lifecycle start and not on becoming leader. - A future now either completes successfully or exceptionally, i.e. it never completes with null. This allows propagation of actual error message to the caller. Added tests for this. - Clarify usage of `committedMaxId` in the set of `pendingSegments` - Rename metric `batch/retries` to `batch/attempts` Changes in follow up PR: - docs (mostly just metrics) - cleanup of empty locks from posse map (both old and new flow) - limit number of requests in each batch - cancel the future if it times out on `LocalTaskActionClient` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
