abhagraw commented on PR #13597: URL: https://github.com/apache/druid/pull/13597#issuecomment-1358892560
> Looks good. Thanks for doing the conversion. For this one, it appears we were able to reuse the code pretty much as-is. That is a good outcome: it allows tests to be converted rapidly. > > I wonder, as we convert, should we remove the old tests? Or, at least leave a comment indicating that they have been converted? Doing so will make it easier to track the conversions as we move beyond having just a handful. > > Other than the formatting issue pointed out below, LGTM. @paul-rogers Currently we only run tests on jvm 8 using the new framework. We need to add support for running on jvm 11 to remove the old framework tests completely. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
