paul-rogers opened a new pull request, #13684:
URL: https://github.com/apache/druid/pull/13684

   The old ITs use DRUID_INTEGRATION_TEST_INDEXER. The new ones use the 
USE_INDEXER env var passed in from the build environment.
   
   The old ITs set an environment variable `USE_INDEXER` in `travis.yml`, which 
Maven then converts to `DRUID_INTEGRATION_TEST_INDEXER`. The previous "indexer" 
PR used the `DRUID_INTEGRATION_TEST_INDEXER` to control the indexer settings in 
the new ITs.
   
   However, it turns out that the new ITs streamline the process: they just use 
`USE_INDEXER` passed in from `travis.yml` without the (unnecessary) translation 
step. This PR, rips out the use of `DRUID_INTEGRATION_TEST_INDEXER` in the new 
IT scripts and replaces that use with `USE_INDEXER` so we get a simple, 
straight pass-through from Travis (or GHA) to the script using the shell 
variables without the need of mucking about in Maven.
   
   <hr>
   
   This PR has:
   
   - [X] been self-reviewed.
   - [X] added documentation for new or modified features or behaviors.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to