tejaswini-imply commented on code in PR #13681: URL: https://github.com/apache/druid/pull/13681#discussion_r1089007941
########## .github/workflows/unit-and-integration-tests-unified.yml: ########## @@ -0,0 +1,160 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +name: Unit & Integration tests CI +on: + push: + branches: + - master + - /^\d+\.\d+\.\d+(-\S*)?$/ # release branches + pull_request: + branches: + - master + - /^\d+\.\d+\.\d+(-\S*)?$/ # release branches + +concurrency: + group: '${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.head_ref || github.ref }}' + cancel-in-progress: true + +jobs: + build: + strategy: + fail-fast: false + matrix: + jdk: [ '8', '11', '17' ] + runs-on: ubuntu-latest + steps: + - name: Checkout branch + uses: actions/checkout@v3 + - name: Cache Maven m2 repository + id: maven + uses: actions/cache@v3 + with: + path: ~/.m2/repository + key: maven-${{ runner.os }}-${{ matrix.jdk }}-${{ hashFiles('**/pom.xml') }} + restore-keys: | + maven-${{ runner.os }}-${{ matrix.jdk }} + - name: Cache targets + id: target + uses: actions/cache@v3 + with: + path: | + ./target + ./extendedset/target + ./hll/target + ./processing/target + ./server/target + ./indexing-hadoop/target + ./web-console/target + ./indexing-service/target + ./services/target + ./benchmarks/target + ./distribution/target + ./integration-tests/target Review Comment: I wonder why target folders need to be cached, from what I gathered, the three types of tests running is doing following things roughly: - unit tests: use mvn test (doesn't need packaging) - it tests(old): use mvn verify (but invokes integration-tests profile and rebuilds entire modules anyhow - should this profile be modified to not build mvn all over again) - it tests(new): reuses fixed docker image in build phase itself and only runs tests against this docker container. Please correct me if I'm missing something here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
