tejaswini-imply commented on code in PR #13681:
URL: https://github.com/apache/druid/pull/13681#discussion_r1091815321
##########
integration-tests/docker/docker-compose.query-error-test.yml:
##########
@@ -78,7 +78,7 @@ services:
druid-it-net:
ipv4_address: 172.172.172.14
ports:
- - 8084:8083
+ - 8086:8083
Review Comment:
The host port mapping from the historical container is not used by the
`query-error` or `query-retry` group of tests. If they do, they'll result in an
error whether the mapped port is 8084 or 8086 due to this hardcoding.
https://github.com/apache/druid/blob/698670c88e3993be971d5c7dda5fed281e32f6de/integration-tests/src/main/java/org/apache/druid/testing/DockerConfigProvider.java#L196-L199
Maybe we can update this in future to take the host port of each service as
input from a config file. For now, 8084 can't be used as it's being used by
mono service in Github-hosted runners.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
