cryptoe commented on code in PR #13755:
URL: https://github.com/apache/druid/pull/13755#discussion_r1118172512
##########
processing/src/main/java/org/apache/druid/frame/processor/ComposingOutputChannelFactory.java:
##########
@@ -114,7 +114,7 @@ public PartitionedOutputChannel
openPartitionedChannel(String name, boolean dele
}
})::get;
writableFrameChannelsBuilder.add(() ->
channel.get().getWritableChannel());
- readableFrameChannelSuppliersBuilder.add(() ->
channel.get().getReadableChannelSupplier().get());
+ readableFrameChannelSuppliersBuilder.add(() ->
channel.get().readOnly().getReadableChannelSupplier().get());
Review Comment:
This will open a readOnly channel for all ComposingOutputChannel's. That
shouldn't be the case no ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
