abhishekagarwal87 commented on code in PR #13902:
URL: https://github.com/apache/druid/pull/13902#discussion_r1166497007
##########
sql/src/main/java/org/apache/druid/sql/calcite/rel/DruidQuery.java:
##########
@@ -1484,16 +1488,16 @@ private ScanQuery toScanQuery()
// Cannot handle this ordering.
// Scan cannot ORDER BY non-time columns.
plannerContext.setPlanningError(
- "SQL query requires order by non-time column %s that is not
supported.",
+ "SQL query requires order by non-time column %s, which is not
supported.",
orderByColumns
);
return null;
}
if (!dataSource.isConcrete()) {
// Cannot handle this ordering.
- // Scan cannot ORDER BY non-time columns.
+ // Scan cannot ORDER BY non-concrete datasources on _any_ column.
plannerContext.setPlanningError(
- "SQL query is a scan and requires order by on a datasource[%s],
which is not supported.",
+ "SQL query requires order by on non-concrete datasource [%s],
which is not supported.",
Review Comment:
I was looking at this PR for some other reason. I don't think we should be
using "concrete" since that concept is not well understood by the users. As a
user, it will not be clear to me to know what a non-concrete data source means.
what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
