[GitHub] [druid] clintropolis commented on a diff in pull request #14130: disable broker parallel merge for Java versions greater than 8 and less than 20 due to apparent bug

Fri, 21 Apr 2023 12:22:50 -0700 


clintropolis commented on code in PR #14130:
URL: https://github.com/apache/druid/pull/14130#discussion_r1174096357


##########
processing/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java:
##########
@@ -895,7 +897,7 @@ public ResultBatch<E> accumulate(ResultBatch<E> 
accumulated, E in)
               accumulated.add(in);
               count++;
               if (count % batchSize == 0) {
-                yield();
+                this.yield();

Review Comment:
   i think cosmetic, intellij was highlighting and complaining about it for 
something that didn't really seem applicable:
   
   <img width="596" alt="Screenshot 2023-04-21 at 12 21 38 PM" 
src="https://user-images.githubusercontent.com/1577461/233718018-c5635140-0e49-47e6-b26e-d133f161b013.png";>
   
   
   and suggested changing it to `this.yield` so i just did it :shrug:



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to