dkoepke commented on PR #14319: URL: https://github.com/apache/druid/pull/14319#issuecomment-1557827869
Regarding naming: For `newestFirst`, "newest" without context might be confusing because it can refer either to when the segment was created/published OR the interval it covers. I believe the behavior is to select the segment with the latest interval (since the segments are sorted by segment ID, and the interval comes first in the ID), so a policy name like `latestInterval` might be clearer? For `leastRestrictive`, perhaps `bestFit` is clearer? My concern is that "least restrictive", while correct, can also refer to a policy that just chooses the widest possible type. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
