kfaraz commented on code in PR #14443: URL: https://github.com/apache/druid/pull/14443#discussion_r1237942806
########## docs/operations/metrics.md: ########## @@ -326,6 +326,12 @@ If `emitBalancingStats` is set to `true` in the Coordinator [dynamic configurati ## General Health +### Service Health + +|Metric|Description|Dimensions|Normal Value| +|------|-----------|----------|------------| +|`druid/heartbeat`| Report service health. For Overlord/Coordinator, the dimension is leader count. `ServiceStatusMonitor` must be enabled. |`heartbeatType`|1| Review Comment: Nit: I think we should prefix this metric with either `cluster/` or `server/` so that this metric becomes `cluster/heartbeat` or `server/heartbeat`. We can add other relevant metrics later which have the same prefix. The prefix `druid/` doesn't seem to give any info about the metric. @suneet-s , @YongGang , what do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
