317brian commented on PR #392:
URL: 
https://github.com/apache/druid-website-src/pull/392#issuecomment-1607917748

   One issue I've found with this process is the "Edit this page" button on the 
doc pages. Because this is built in the intermediate repo using the `latest` or 
the `version` doc directory, the edit URL is incorrect:
   
   `https://github.com/apache/druid/edit/master/docs/latest/design/index.md`
   
   It doesn't look like there is an easy way to change it to not include 
latest, since this is the config:
   
   ```
   "editUrl": "https://github.com/apache/druid/edit/master/";,
   ```
   
   So I guess the question is which trade off do we want to make: 
   
   - Continue building the site twice, ie build once in `druid` and copy the 
HTML files to `druid-website-src` and preserve the edit button functionality
   - Turn off the `Edit this page` button and build only in the 
`druid-website-src` repo.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to