vtlim commented on code in PR #14459:
URL: https://github.com/apache/druid/pull/14459#discussion_r1242793818


##########
docs/tutorials/tutorial-jupyter-docker.md:
##########
@@ -33,12 +33,15 @@ You can run the following combination of applications:
 * [Jupyter only](#start-only-the-jupyter-container)
 * [Jupyter and Druid](#start-jupyter-and-druid)
 * [Jupyter, Druid, and Kafka](#start-jupyter-druid-and-kafka)
+* [Kafka and Jupyter](#start-kafka-and-jupyter)
 
 ## Prerequisites
 
 Jupyter in Docker requires that you have **Docker** and **Docker Compose**.
 We recommend installing these through [Docker 
Desktop](https://docs.docker.com/desktop/).
 
+For ARM-based devices, see [Tutorial setup for ARM-based 
devices](#tutorial-setup-for-arm-based-devices) for instructions.

Review Comment:
   ```suggestion
   For ARM-based devices, see [Tutorial setup for ARM-based 
devices](#tutorial-setup-for-arm-based-devices).
   ```



##########
docs/tutorials/tutorial-jupyter-docker.md:
##########
@@ -63,6 +66,8 @@ docker compose --profile jupyter up -d
 The Docker Compose file assigns `8889` for the Jupyter port.
 You can override the port number by setting the `JUPYTER_PORT` environment 
variable before starting the Docker application.
 
+If Druid is running local to the same machine as Jupyter, before starting a 
tutorial, set the `host` variable to `host.docker.internal` within the notebook.

Review Comment:
   Maybe add example?
   `````suggestion
   If Druid is running local to the same machine as Jupyter, before starting a 
tutorial, set the `host` variable to `host.docker.internal` within the 
notebook. For example:
   ```
   host = "host.docker.internal"
   ```
   `````



##########
docs/tutorials/tutorial-jupyter-docker.md:
##########
@@ -85,6 +90,20 @@ In the same directory as `docker-compose.yaml` and 
`environment`, start the appl
 DRUID_VERSION={{DRUIDVERSION}} docker compose --profile all-services up -d
 ```
 
+### Start Kafka and Jupyter
+
+If you already have Druid running externally, such as an existing cluster or a 
dedicated infrastructure for Druid, you can run only Kafka and Jupyter in the 
Docker Compose environment to complete the tutorials.

Review Comment:
   ```suggestion
   If you already have Druid running externally, such as an existing cluster or 
a dedicated infrastructure for Druid, you can run the Docker containers for 
Kafka and Jupyter only.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to