adarshsanjeev commented on code in PR #14476:
URL: https://github.com/apache/druid/pull/14476#discussion_r1243557401
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/util/MultiStageQueryContext.java:
##########
@@ -204,6 +211,16 @@ public static int getRowsPerSegment(final QueryContext
queryContext)
);
}
+ public static MSQSelectDestination getSelectDestination(final QueryContext
queryContext)
+ {
+ return MSQSelectDestination.valueOf(
Review Comment:
It would currently return an IAE with "value not found in enum", but the
error message could be improved here. I think that's a good point, that we
should make it more user friendly. This is true for all other enum query
context parameters (workerAssignementStrategy, clusterStatisticsMergeMode etc).
I'll make this change in a separate PR and include all other query context
parameters as well.
One thought, maybe DURABLE_STORAGE should be present always so that the user
knows that it is an option and can configure durable storage if needed. If it
is not enabled, we would throw an exception accordingly from wherever it is
writing the results anyway. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
