gianm commented on issue #14502: URL: https://github.com/apache/druid/issues/14502#issuecomment-1614866404
The `CuratorModuleTest` case `exitsJvmWhenMaxRetriesExceeded` relies on `NoExitSecurityManager` to trap `System.exit`. Security managers are being removed gradually from Java 18+ (https://openjdk.org/jeps/411). The test will need to be rewritten or deleted. IMO a good option would be to adjust `CuratorModuleTest` to subclass `CuratorModule` and override `shutdown(lifecycle)`. The overridden method should set an `AtomicBoolean` in the subclass rather than calling `System.exit(1)`. Then, the test case should check the `AtomicBoolean` rather than using `ExpectedSystemExit`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
