gianm commented on code in PR #13773:
URL: https://github.com/apache/druid/pull/13773#discussion_r1254652197


##########
sql/src/main/java/org/apache/druid/sql/calcite/rel/DruidQuery.java:
##########
@@ -1380,11 +1383,21 @@ private WindowOperatorQuery toWindowQuery()
       return null;
     }
 
+    final DataSource myDataSource;
+    if (dataSource instanceof TableDataSource) {

Review Comment:
   What if the underlying datasource is a `join` or `unnest`? Do we need 
special handling or is that taken care of by the `WindowOperatorQuery` itself?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to