kfaraz commented on PR #14642: URL: https://github.com/apache/druid/pull/14642#issuecomment-1647287084
Yes, @maytasm , I agree. With the recent improvements made in #14639 and the automatic Coordinator kill being a thing, I am not sure if we would really gain a lot of perf benefits here in most cases. But since we cannot prevent users from submitting a `kill` task (it is allowed by the console after all), it would make sense to improve this action, especially since it is done in a critical section of the `TaskLockbox`. In my opinion, the best way forward is to check if we can fire a single `DELETE` with the right filter on interval, rather than a batch of DELETEs. It would not require use to have any new configs or worry about partial success. cc: @jasonk000 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
