gianm commented on code in PR #14581:
URL: https://github.com/apache/druid/pull/14581#discussion_r1272473594
##########
server/src/test/java/org/apache/druid/server/coordinator/duty/CompactSegmentsTest.java:
##########
@@ -2465,4 +2232,18 @@ public void
testFindMaxNumTaskSlotsUsedByOneCompactionTaskWhenIsSequentialMode()
Assert.assertEquals(1,
CompactSegments.findMaxNumTaskSlotsUsedByOneCompactionTask(tuningConfig));
}
}
+
+ private static ArgumentCaptor<Object> setUpMockClient(final OverlordClient
mockClient)
Review Comment:
I am not sure, I haven't studied this class enough to answer that question.
The class was like this already: it used both `TestDruidLeaderClient` and a
Mockito mock of `HttpIndexingServiceClient`. I was trying to update it to use
`OverlordClient` without redesigning it. I'd like to leave it as-is, if you're
OK with that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
