github-code-scanning[bot] commented on code in PR #14748:
URL: https://github.com/apache/druid/pull/14748#discussion_r1288440650
##########
sql/src/test/java/org/apache/druid/sql/calcite/CalciteSelectQueryTest.java:
##########
@@ -1923,4 +1927,112 @@
)
);
}
+
+ @Test
+ public void testCountDistinctNonApproximateEmptySet()
+ {
+ cannotVectorize();
+ testQuery(
+ PLANNER_CONFIG_DEFAULT.withOverrides(
+ ImmutableMap.of(
+ PlannerConfig.CTX_KEY_USE_APPROXIMATE_COUNT_DISTINCT, false)),
+ "select count(distinct m1) from druid.foo where m1 < -1.0",
+ CalciteTests.REGULAR_USER_AUTH_RESULT,
+ ImmutableList.of(
+ GroupByQuery.builder()
+ .setDataSource(
+ GroupByQuery.builder()
+ .setDataSource(CalciteTests.DATASOURCE1)
+ .setInterval(querySegmentSpec(Filtration.eternity()))
+ .setGranularity(Granularities.ALL)
+ .setDimensions(
+ dimensions(
+ new DefaultDimensionSpec("m1", "d0",
ColumnType.FLOAT)))
+ .setDimFilter(
+ range("m1", ColumnType.LONG, null, -1.0, false,
true))
+ .build())
+ .setInterval(querySegmentSpec(Filtration.eternity()))
+ .setGranularity(Granularities.ALL)
+ // .setPostAggregatorSpecs(null)
+ .setAggregatorSpecs(aggregators(new
CountAggregatorFactory("a0")))
+ .build()
+
+ ),
+ ImmutableList.of(new Object[] {0l}));
+ }
+
+ @Test
+ public void testCountDistinctNonApproximateBasic()
+ {
+ cannotVectorize();
+ testQuery(
+ PLANNER_CONFIG_DEFAULT.withOverrides(
+ ImmutableMap.of(
+ PlannerConfig.CTX_KEY_USE_APPROXIMATE_COUNT_DISTINCT, false)),
+ "select count(distinct m1) from druid.foo where m1 < 111.0",
+ CalciteTests.REGULAR_USER_AUTH_RESULT,
+ ImmutableList.of(
+ GroupByQuery.builder()
+ .setDataSource(
+ GroupByQuery.builder()
+ .setDataSource(CalciteTests.DATASOURCE1)
+ .setInterval(querySegmentSpec(Filtration.eternity()))
+ .setGranularity(Granularities.ALL)
+ .setDimensions(
+ dimensions(
+ new DefaultDimensionSpec("m1", "d0",
ColumnType.FLOAT)))
+ .setDimFilter(
+ range("m1", ColumnType.LONG, null, 111.0, false,
true))
+ .build())
+ .setInterval(querySegmentSpec(Filtration.eternity()))
+ .setGranularity(Granularities.ALL)
+ .setAggregatorSpecs(aggregators(new
CountAggregatorFactory("a0")))
+ .build()
+
+ ),
+ ImmutableList.of(new Object[] {6l}));
+ }
+
+ @Test
+ public void testCountDistinctNonApproximateWithFilter()
+ {
+ long expectedCount;
Review Comment:
## Unread local variable
Variable 'long expectedCount' is never read.
[Show more
details](https://github.com/apache/druid/security/code-scanning/5423)
##########
sql/src/test/java/org/apache/druid/sql/calcite/CalciteSelectQueryTest.java:
##########
@@ -1923,4 +1927,112 @@
)
);
}
+
+ @Test
+ public void testCountDistinctNonApproximateEmptySet()
+ {
+ cannotVectorize();
+ testQuery(
+ PLANNER_CONFIG_DEFAULT.withOverrides(
+ ImmutableMap.of(
+ PlannerConfig.CTX_KEY_USE_APPROXIMATE_COUNT_DISTINCT, false)),
+ "select count(distinct m1) from druid.foo where m1 < -1.0",
+ CalciteTests.REGULAR_USER_AUTH_RESULT,
+ ImmutableList.of(
+ GroupByQuery.builder()
+ .setDataSource(
+ GroupByQuery.builder()
+ .setDataSource(CalciteTests.DATASOURCE1)
+ .setInterval(querySegmentSpec(Filtration.eternity()))
+ .setGranularity(Granularities.ALL)
+ .setDimensions(
+ dimensions(
+ new DefaultDimensionSpec("m1", "d0",
ColumnType.FLOAT)))
+ .setDimFilter(
+ range("m1", ColumnType.LONG, null, -1.0, false,
true))
+ .build())
+ .setInterval(querySegmentSpec(Filtration.eternity()))
+ .setGranularity(Granularities.ALL)
+ // .setPostAggregatorSpecs(null)
+ .setAggregatorSpecs(aggregators(new
CountAggregatorFactory("a0")))
+ .build()
+
+ ),
+ ImmutableList.of(new Object[] {0l}));
+ }
+
+ @Test
+ public void testCountDistinctNonApproximateBasic()
+ {
+ cannotVectorize();
+ testQuery(
+ PLANNER_CONFIG_DEFAULT.withOverrides(
+ ImmutableMap.of(
+ PlannerConfig.CTX_KEY_USE_APPROXIMATE_COUNT_DISTINCT, false)),
+ "select count(distinct m1) from druid.foo where m1 < 111.0",
+ CalciteTests.REGULAR_USER_AUTH_RESULT,
+ ImmutableList.of(
+ GroupByQuery.builder()
+ .setDataSource(
+ GroupByQuery.builder()
+ .setDataSource(CalciteTests.DATASOURCE1)
+ .setInterval(querySegmentSpec(Filtration.eternity()))
+ .setGranularity(Granularities.ALL)
+ .setDimensions(
+ dimensions(
+ new DefaultDimensionSpec("m1", "d0",
ColumnType.FLOAT)))
+ .setDimFilter(
+ range("m1", ColumnType.LONG, null, 111.0, false,
true))
+ .build())
+ .setInterval(querySegmentSpec(Filtration.eternity()))
+ .setGranularity(Granularities.ALL)
+ .setAggregatorSpecs(aggregators(new
CountAggregatorFactory("a0")))
+ .build()
+
+ ),
+ ImmutableList.of(new Object[] {6l}));
+ }
+
+ @Test
+ public void testCountDistinctNonApproximateWithFilter()
+ {
+ long expectedCount;
+ AggregatorFactory aggregate;
Review Comment:
## Unread local variable
Variable 'AggregatorFactory aggregate' is never read.
[Show more
details](https://github.com/apache/druid/security/code-scanning/5424)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
