PramodSSImmaneni commented on code in PR #13982:
URL: https://github.com/apache/druid/pull/13982#discussion_r1293967186
##########
server/src/main/java/org/apache/druid/segment/realtime/appenderator/AppenderatorImpl.java:
##########
@@ -1146,9 +1160,9 @@ private void initializeExecutors()
if (persistExecutor == null) {
// use a blocking single threaded executor to throttle the firehose when
write to disk is slow
persistExecutor = MoreExecutors.listeningDecorator(
- Execs.newBlockingSingleThreaded(
+ Execs.newBlockingThreaded(
"[" + StringUtils.encodeForFormat(myId) +
"]-appenderator-persist",
- maxPendingPersists
+ persistThreads, maxPendingPersists
Review Comment:
Was looking at this, wouldn't the shutdown on the executor interrupt any
running threads anyway. I mean even with single thread the pending persist
would not complete. Also when abandoning the segments are not going to get
pushed to deep storage and nor would the kafka offsets be committed isn't it.
So any pending persists in the queue wouldn't matter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
