kfaraz opened a new pull request, #14923:
URL: https://github.com/apache/druid/pull/14923
### Changes
#### Remove config `decommissioningMaxPercentOfMaxSegmentsToMove`
- It is a convoluted config 😅 ,
- It is not really needed anymore since in `smartSegmentLoading`, we
prioritize move from decommissioning nodes, i.e. this value is always 100%.
This is desirable in all cases as the quicker we move things from
decommissioning nodes, the quicker they can be terminated.
#### Remove config `maxNonPrimaryReplicantsToLoad`
This was added in #11135 and met two requirements:
- Prevent coordinator runs from getting stuck assigning too many segments to
historicals
- Prevent load of replicas from competing with load of unavailable segments
Both of these requirements are now already met thanks to:
- Round-robin segment assignment: This ensures that asssignments in a single
coordinator run happen very fast
- Prioritization in the new coordinator: Load of unavailable segments is
always prioritized over load of under-replicated segment
- Modifications to `replicationThrottleLimit`: The
`replicationThrottleLimit` now ensures that for any tier, the sum of the number
of replicas in load queue at start of a coordinator run and the number of
replicas assigned during the run is always within the limit. So, it can perform
the same function as `maxNonPrimaryReplicantsToLoad` except
`replicationThrottleLimit` is per tier.
- `smartSegmentLoading` (true by default) takes care of all of the above
without requiring the user to change any config
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
