somu-imply opened a new pull request, #14924:
URL: https://github.com/apache/druid/pull/14924

   …we update the vectorized aggs properly
   
   Polaris defined a fixed schema where a column say `instant` is long, but 
from the segment metadata instant was a string. If we run the query
   ```
   {
     "queryType":"segmentMetadata",
     "dataSource":"test_agent_usage_snapshots",
     "intervals":["2023-01-01/2024-01-01"]
   }
   ```
   We could see the schema to be STRING for segments.
   ```
   {
                   "typeSignature": "STRING",
                   "type": "STRING",
                   "hasMultipleValues": false,
                   "hasNulls": false,
                   "size": 0,
                   "cardinality": 1,
                   "minValue": "0",
                   "maxValue": "0",
                   "errorMessage": null
               }
    ```
    
    This causes queries with aggregation such as
    ```
    "aggregations": [
       {
         "type": "floatLast",
         "name": "a0",
         "fieldName": "<string_col>",
         "timeColumn": "__time"
       }
     ],
    ```  
   to fail when used in vectorized mode. This is because vectorized aggs need 
these cast supports. Till that is done, this PR fixes the issue by going down 
the non-vectorized route      
   
   - [ ] been self-reviewed.
      - [ ] using the [concurrency 
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
 (Remove this item if the PR doesn't have any relation to concurrency.)
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] a release note entry in the PR description.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked 
related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in 
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
   - [ ] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [ ] added integration tests.
   - [ ] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to