LakshSingla commented on PR #14933:
URL: https://github.com/apache/druid/pull/14933#issuecomment-1701357840
WDYT of renaming the method that adds the metric as
`.setMetric("segment/unavailable/count", 100)` instead of
`.setMetricAndValue("segment/unavailable/count", 100)` due to following reasons:
1. The other methods in the builder don't specify `andValue` at the end,
i.e. they are named as `setDimension` instead of `setDimensionAndValue, and
`setMetric` seems more consistent.
2. It is kinda implicit that the second arg would be a value, and
`setMetric` seems cleaner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
