gianm commented on code in PR #14976:
URL: https://github.com/apache/druid/pull/14976#discussion_r1326106411
##########
processing/src/main/java/org/apache/druid/math/expr/Function.java:
##########
@@ -2224,6 +2224,89 @@ public <T> ExprVectorProcessor<T>
asVectorProcessor(Expr.VectorInputBindingInspe
}
}
+ /**
+ * SQL function "x IS NOT DISTINCT FROM y". Very similar to "x = y", i.e.
{@link BinEqExpr}, except this function
+ * never returns null, and this function considers NULL itself to be
not-distinct-from NULL.
+ */
+ class IsNotDistinctFromFunc implements Function
+ {
+ @Override
+ public String name()
+ {
+ return "notdistinctfrom";
Review Comment:
Yeah, I was modeling the names after `isnull` and `notnull`. Like,
- SQL `IS NULL` -> native `isnull`
- SQL `IS NOT NULL` -> native `notnull` (drop the "is")
I would prefer to keep this whole family of functions consistent with each
other. IMO if we _also_ want consistency with SQL then we should make new
aliases for `isnull` and `notnull` too. That'd be fine by me, fwiw, although I
don't personally feel it's necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
