LakshSingla commented on code in PR #14981:
URL: https://github.com/apache/druid/pull/14981#discussion_r1326459629
##########
extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/exec/MSQFaultsTest.java:
##########
@@ -356,4 +359,44 @@ public void testTooManyInputFiles() throws IOException
.setExpectedMSQFault(new TooManyInputFilesFault(numFiles,
Limits.MAX_INPUT_FILES_PER_WORKER, 2))
.verifyResults();
}
+
+ @Test
+ public void testUnionAllIsDisallowed()
+ {
+ final RowSignature rowSignature =
+ RowSignature.builder().add("__time", ColumnType.LONG).build();
+ testIngestQuery()
Review Comment:
Easier to test the exceptions in `testIngestQuery's` since they have very
few precondition requirements. 😓 `testSelectQuery` does require a lot of
precondition requirements even if they are not used. The test framework
requires a refactor, but I'll change this to `testSelectQuery`, to make it less
ambiguous.
##########
extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/exec/MSQFaultsTest.java:
##########
@@ -356,4 +359,44 @@ public void testTooManyInputFiles() throws IOException
.setExpectedMSQFault(new TooManyInputFilesFault(numFiles,
Limits.MAX_INPUT_FILES_PER_WORKER, 2))
.verifyResults();
}
+
+ @Test
+ public void testUnionAllIsDisallowed()
+ {
+ final RowSignature rowSignature =
+ RowSignature.builder().add("__time", ColumnType.LONG).build();
+ testIngestQuery()
Review Comment:
Easier to test the exceptions in `testIngestQuery's` since they have very
few precondition requirements. 😓 `testSelectQuery` does require a lot of
precondition requirements even if they are not used. The test framework
requires a refactor, but I'll change this to `testSelectQuery`, to make it less
ambiguous.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
