LakshSingla opened a new pull request, #15017:
URL: https://github.com/apache/druid/pull/15017

   ### Description
   
   https://github.com/apache/druid/pull/14808 introduced `auto` mode for 
calculating the size to be reserved for inlining the subquery results per 
query, however, I incorrectly used `druid.broker.http.numConnections` as the 
maximum number of queries that the broker can serve concurrently instead of 
`druid.server.http.numThreads`. The former refers to the connections per query 
that the broker can use to contact data nodes, whereas the latter refers to the 
number of threads in the broker reserved for serving the queries (which 
represents the correct figure). 
   
   This PR corrects that patch.
   
   
   <hr>
   
   
   This PR has:
   
   - [x] been self-reviewed.
      - [ ] using the [concurrency 
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
 (Remove this item if the PR doesn't have any relation to concurrency.)
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] a release note entry in the PR description.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked 
related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in 
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
   - [ ] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [ ] added integration tests.
   - [ ] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to