pranavbhole commented on code in PR #15056:
URL: https://github.com/apache/druid/pull/15056#discussion_r1340916372
##########
processing/src/main/java/org/apache/druid/java/util/common/StringUtils.java:
##########
@@ -373,16 +373,24 @@ public static String nonStrictFormat(String message,
Object... formatArgs)
if (formatArgs == null || formatArgs.length == 0) {
return message;
}
+ if (message == null) {
Review Comment:
Based on comments, I found the instances where we could potentially pass
null as formatString. I fixed all of them I could find in this PR. I am still
doubtful about adding precondition check to nonStrictFormat as it is used at
tons of places. I removed the change here and fixing the invokers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
