kgyrtkirk commented on code in PR #15057:
URL: https://github.com/apache/druid/pull/15057#discussion_r1342388044
##########
sql/src/main/java/org/apache/druid/sql/calcite/rel/Windowing.java:
##########
@@ -88,9 +88,9 @@ public class Windowing
private static final ImmutableMap<String, ProcessorMaker> KNOWN_WINDOW_FNS =
ImmutableMap
.<String, ProcessorMaker>builder()
.put("LAG", (agg) ->
- new WindowOffsetProcessor(agg.getColumn(0), agg.getOutputName(),
-agg.getConstantInt(1)))
+ new WindowOffsetProcessor(agg.getColumn(0), agg.getOutputName(),
-agg.getConstantInt(1, 1)))
Review Comment:
actually; I don't really see any existing documentation for LEAD/LAG; and
because I don't see any either for windowing - I think that should be added
separately along with LEAD/LAG
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
