somu-imply commented on code in PR #15075:
URL: https://github.com/apache/druid/pull/15075#discussion_r1348986782
##########
processing/src/main/java/org/apache/druid/query/JoinDataSource.java:
##########
@@ -476,10 +476,18 @@ private Function<SegmentReference, SegmentReference>
createSegmentMapFunctionInt
.orElse(null)
)
);
-
+ final Function<SegmentReference, SegmentReference> baseMapFn;
+ if (left instanceof JoinDataSource) {
Review Comment:
I'll add a comment as into why we are not using the isConcrete() check and
instead using the instanceof check here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
