AmatyaAvadhanula commented on code in PR #15039: URL: https://github.com/apache/druid/pull/15039#discussion_r1356677140
########## server/src/main/java/org/apache/druid/segment/realtime/appenderator/SinkQuerySegmentWalker.java: ########## @@ -92,6 +94,8 @@ public class SinkQuerySegmentWalker implements QuerySegmentWalker private final Cache cache; private final CacheConfig cacheConfig; private final CachePopulatorStats cachePopulatorStats; + private final ConcurrentMap<SegmentDescriptor, SegmentDescriptor> newIdToBasePendingSegment Review Comment: Yes. We could do it when a segment is unannounced but it will not be queried subsequently and it isn't likely for there to be a significant overhead due to such entries -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
