clintropolis commented on code in PR #15183:
URL: https://github.com/apache/druid/pull/15183#discussion_r1362785941
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/scan/ExternalColumnSelectorFactory.java:
##########
@@ -97,7 +103,11 @@ public void inspectRuntimeShape(RuntimeShapeInspector
inspector)
public Object getObject()
{
try {
- return delegateDimensionSelector.getObject();
+ ExpressionType expressionType =
ExpressionType.fromColumnType(dimensionSpec.getOutputType());
Review Comment:
should probably save this outside of getObject so don't have to recreate
every time (it uses interned objects so it won't be making new ones really, but
could still save some overhead)
##########
extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/exec/MSQArraysTest.java:
##########
@@ -857,6 +858,53 @@ public void testScanWithOrderByOnDoubleArray()
.verifyResults();
}
+ @Test
+ public void testScanExternBooleanArray()
Review Comment:
might be nice to add some other mismatched types, maybe even some that are
not convertible to show what happens (like maybe json input to a double?)
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/scan/ExternalColumnSelectorFactory.java:
##########
@@ -195,7 +205,13 @@ public boolean isNull()
public Object getObject()
{
try {
- return delegateColumnValueSelector.getObject();
+ ExpressionType expressionType =
ExpressionType.fromColumnType(rowSignature
Review Comment:
same comment on saving outside of getObject
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
