LakshSingla opened a new pull request, #15269:
URL: https://github.com/apache/druid/pull/15269
### Description
ServiceClientImpl logs the cause of every retry, even though we are retrying
the connection attempt. This leads to slight pollution in the logs because a
lot of the time, the reason for retrying is the same. This is seen primarily in
MSQ, when the worker task hasn't launched yet however controller attempts to
connect to the worker task, which can lead to scary-looking messages (with
`INFO` log level), even though they are normal.
This PR changes the logging logic to log every 10 (arbitrary number) retries
instead of every retry, to reduce the pollution of the logs.
Note: If there are no retries left, the client returns an exception, which
would get thrown up by the caller, and therefore this change doesn't hide any
important information.
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
