gianm commented on code in PR #15264:
URL: https://github.com/apache/druid/pull/15264#discussion_r1377854222
##########
distribution/docker/Dockerfile:
##########
@@ -17,7 +17,7 @@
# under the License.
#
-ARG JDK_VERSION=11
+ARG JDK_VERSION=17
Review Comment:
I am good with this, and in fact I prefer it 🙂
##########
distribution/docker/Dockerfile:
##########
@@ -17,7 +17,7 @@
# under the License.
#
-ARG JDK_VERSION=11
+ARG JDK_VERSION=17
# The platform is explicitly specified as x64 to build the Druid distribution.
Review Comment:
I think we can raise an Infra ticket, or ask in ASF Slack, to adjust how the
images get built. (Or at least ask how they get built.) If it's possible to
publish ARM images too that would be nice.
##########
distribution/docker/Dockerfile:
##########
@@ -17,7 +17,7 @@
# under the License.
#
-ARG JDK_VERSION=11
+ARG JDK_VERSION=17
Review Comment:
I am good with this, and in fact I prefer it 🙂
##########
distribution/docker/Dockerfile:
##########
@@ -49,17 +49,8 @@ RUN --mount=type=cache,target=/root/.m2 VERSION=$(mvn -B -q
org.apache.maven.plu
&& tar -zxf ./distribution/target/apache-druid-${VERSION}-bin.tar.gz -C /opt \
&& mv /opt/apache-druid-${VERSION} /opt/druid
-FROM busybox:1.34.1-glibc as busybox
-
-FROM gcr.io/distroless/java$JDK_VERSION-debian11
-LABEL maintainer="Apache Druid Developers <[email protected]>"
-
-COPY --from=busybox /bin/busybox /busybox/busybox
-RUN ["/busybox/busybox", "--install", "/bin"]
-
-# Predefined builtin arg, see:
https://docs.docker.com/engine/reference/builder/#automatic-platform-args-in-the-global-scope
+FROM alpine as bash-static
Review Comment:
What's the new usage of `alpine` for? Would it make sense to pin this to a
specific version so the build is more reproducible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
