janjwerner-confluent commented on code in PR #15449:
URL: https://github.com/apache/druid/pull/15449#discussion_r1408765217
##########
extensions-core/kubernetes-extensions/src/main/java/org/apache/druid/k8s/discovery/DefaultK8sApiClient.java:
##########
@@ -80,8 +80,7 @@ public DiscoveryDruidNodeList listPods(
)
{
try {
- V1PodList podList = coreV1Api.listNamespacedPod(podNamespace, null,
null, null, null, labelSelector, 0, null, null, null, null);
- Preconditions.checkState(podList != null, "WTH: NULL podList");
+ V1PodList podList = coreV1Api.listNamespacedPod(podNamespace, null,
null, null, null, labelSelector, 0, null, null, null, null, false);
Preconditions.checkState(podList != null, "WTH: NULL podList");
Review Comment:
From:
https://javadoc.io/static/io.kubernetes/client-java-api/19.0.0/io/kubernetes/client/openapi/apis/CoreV1Api.html#listNamespacedPod(java.lang.String,java.lang.String,java.lang.Boolean,java.lang.String,java.lang.String,java.lang.String,java.lang.Integer,java.lang.String,java.lang.String,java.lang.Boolean,java.lang.Integer,java.lang.Boolean)
sendInitialEvents - `sendInitialEvents=true` may be set together with
`watch=true`. In that case, the watch stream will begin with synthetic events
to produce the current state of objects in the collection. Once all such events
have been sent, a synthetic \"Bookmark\" event will be sent. The bookmark will
report the ResourceVersion (RV) corresponding to the set of objects, and be
marked with `\"k8s.io/initial-events-end\": \"true\"` annotation. Afterwards,
the watch stream will proceed as usual, sending watch events corresponding to
changes (subsequent to the RV) to objects watched. When `sendInitialEvents`
option is set, we require `resourceVersionMatch` option to also be set. The
semantic of the watch request is as following: - `resourceVersionMatch` =
NotOlderThan is interpreted as \"data at least as new as the provided
`resourceVersion`\" and the bookmark event is send when the state is synced to
a `resourceVersion` at least as fresh as the one provided by the ListOptions.
If
`resourceVersion` is unset, this is interpreted as \"consistent read\" and the
bookmark event is send when the state is synced at least to the moment when
request started being processed. - `resourceVersionMatch` set to any other
value or unset Invalid error is returned. Defaults to true if
`resourceVersion=\"\"` or `resourceVersion=\"0\"` (for backward compatibility
reasons) and to false otherwise. (optional)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
