kgyrtkirk commented on code in PR #15467:
URL: https://github.com/apache/druid/pull/15467#discussion_r1412227877
##########
server/src/main/java/org/apache/druid/server/QueryLifecycle.java:
##########
@@ -347,7 +347,7 @@ public void emitLogsAndMetrics(
if (e != null) {
statsMap.put("exception", e.toString());
- if (baseQuery.context().isDebug()) {
+ if (baseQuery.context().isDebug() || e.getMessage() == null) {
Review Comment:
interesting; reading this I had an idea: how about:
* keeping a `Set<Integer>` around
* compute `h = hash(Throwables.getStackTraceAsString(e))`
* if its the first occurance of the exception (not in the set) - log it with
backtrace along; and also leave `hash = ${h}` behind in some form
* later when the same exception repeats (same hash) -> just log a reference
to it's hash so it can be looked up in the logs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
